nopCommerce
nopCommerce copied to clipboard
nopSolutions
CSS. Use Less or Sass or Stylus
I don't begin to understand how to customize the current theme into something original given a 8,754 line CSS file compiled from what looks like many different sources. Why isn't this better organized? Why aren't the LESS/SASS files you are obviously building from included somewhere in the project?
If I'm wrong, that would make me the happiest person in the world. Have I made a mistake? Missed something?
I can of course roll my own, but I just want to customize what's there in a friendly manner.
Mark, I do not remember any Sass as part of the nop default css styling. You can add your own custom styling through your own custom theme based on the nop default theme. See the documentation. If you do not mind me asking why do you believe there are sass components. The styling for the default theme has not changed much over the years.
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Mark Drake @.> Sent: Tuesday, October 19, 2021 12:39:14 PM To: nopSolutions/nopCommerce @.> Cc: Subscribed @.***> Subject: Re: [nopSolutions/nopCommerce] CSS. Use Less or Sass or Stylus (#368)
I don't begin to understand how to customize the current theme into something original given a 8,754 line CSS file compiled from what looks like many different sources. Why isn't this better organized? Why aren't the LESS/SASS files you are obviously building from included somewhere in the project?
If I'm wrong, that would make me the happiest person in the world. Have I made a mistake? Missed something?
I can of course roll my own, but I just want to customize what's there in a friendly manner.
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/nopSolutions/nopCommerce/issues/368#issuecomment-947046297, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKD4KOZ2HXLRR3YSFYTNHCTUHXCOFANCNFSM4BY26F6A.
@glhays what is the likelihood of a PR that addresses the main theme? I would like to work with the team if possible to bring the default theme more up to date and provide a solid base for future theme development (or just quickly changing values to match branding).
I have no idea on that? This issue #368 was recently reopened and the tag is onhold/maybe won't. Likelihood????
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Mark Drake @.> Sent: Tuesday, October 19, 2021 4:12:33 PM To: nopSolutions/nopCommerce @.> Cc: Gregory Hays @.>; Mention @.> Subject: Re: [nopSolutions/nopCommerce] CSS. Use Less or Sass or Stylus (#368)
@glhayshttps://github.com/glhays what is the likelihood of a PR that addresses the main theme? I would like to work with the team if possible to bring the default theme more up to date and provide a solid base for future theme development (or just quickly changing values to match branding).
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/nopSolutions/nopCommerce/issues/368#issuecomment-947173147, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AKD4KO22ML5NF7PDDQI3WA3UHX3ODANCNFSM4BY26F6A.
@AndreiMaz I see from time to time you've updated this issue regarding SASS. Would you be open to sharing more detail about the status of this ticket and if the team would accept a PR?
There are many ways to go about addressing a build system (to transpile the SASS). Does your team have a preference? This can be done in a way as not to inconvenience anyone - the resulting CSS file can still be included in the project. Perhaps it's best not to ship with any build system at all and allow the SASS to accompany the project for anyone who wants to make use of it.
All the best,
After some consideration we've decided not to implement this functionality