avrgirl-arduino icon indicating copy to clipboard operation
avrgirl-arduino copied to clipboard

Update SerialPort to v10, fixing several breaking changes. I need a hand with tests.

Open obra opened this issue 2 years ago • 1 comments

IMPORTANT: This doesn't currently pass tests due to how SerialPort.list gets mocked. I'm having a hard time understanding the correct way to fix the mocking library.

SerialPort 10 is dramatically easier for Electron apps to bundle. I'd really love to get avrgirl-arduino updated to work with it.

Manual testing seems to indicate that the changes work, including the behaviour that's failing tests. It looks like there's a dep issue with avrga-tester that's blocking my ability to run through the test-pilot process. I'm really sorry about that :/

image

Signed-off-by: Jesse Vincent [email protected]

Description

Please review the contribution and code of conduct guidelines.

Please include a summary of the proposed improvement or addressed issue.

Fixes/addresses (If applicable) # (issue)

Type of change

Please delete options that are not relevant.

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • [ ] This change requires a documentation update

Checklist:

  • [ ] My code follows the style guidelines of this project
  • [ ] I have performed a self-review of my own code
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] My changes generate no new warnings
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] New and existing unit tests pass locally with my changes
  • [ ] Any dependent changes have been merged and published in downstream modules
  • [ ] Changes have been manually tested (please provide information on test platform using the fields below)

Test / Development Platform Information

  • Operating system and version
  • Avrgirl Arduino version
  • NodeJS version
  • Arduino Board being used

obra avatar Mar 24 '22 02:03 obra

@noopkat this is as much a request for feedback as anything else. When you have the time, I'd love to know whether this is something to push on or not.

obra avatar Mar 24 '22 02:03 obra