avrgirl-arduino icon indicating copy to clipboard operation
avrgirl-arduino copied to clipboard

setting the rts pin to false when the dtr pin is used to reset boards.

Open tocalvo opened this issue 7 years ago • 7 comments

Hi! I'm adding the Freaks Car (http://www.elecfreaks.com/estore/freakscar-robot-starter-kit-741.html) to Bitbloq ( our robot/boards family is growing 😄 )

But when i try to program it with avrGirl always give me a timeout, i was searching and it's because the board never resets on the flashing process. I see that the reset is done in avrgir setting the DTR and RTS pins to true. But setting DTR to true, and RTS to false it works. I try with a bqZum and with an Arduino UNO, and works too. So i created the pull request because looks good. Buuut I'm not sure if this change can affect to more boards, i'm searching more info about the reset process on Arduino, but only see information about the DTR pin, never about the RTS, i'm not sure if is used too. Can you test it in the other boards? if you find some board with errors setting the RTS to false, i can change the pull request to add a RTS option in the boards.json to handle this case in the reset.

Thanks!

tocalvo avatar May 16 '17 15:05 tocalvo

Coverage Status

Coverage remained the same at 44.118% when pulling 9071b07135c3887f87de73a5b093542c86edf7d1 on tocalvo:avoid-rts-on-board-reset into 8b8a67bb2b415af29542dc2cf13b535987bf200e on noopkat:master.

coveralls avatar May 16 '17 15:05 coveralls

Coverage Status

Coverage remained the same at 44.118% when pulling 9071b07135c3887f87de73a5b093542c86edf7d1 on tocalvo:avoid-rts-on-board-reset into 8b8a67bb2b415af29542dc2cf13b535987bf200e on noopkat:master.

coveralls avatar May 16 '17 15:05 coveralls

Coverage Status

Coverage remained the same at 44.118% when pulling 9071b07135c3887f87de73a5b093542c86edf7d1 on tocalvo:avoid-rts-on-board-reset into 8b8a67bb2b415af29542dc2cf13b535987bf200e on noopkat:master.

coveralls avatar May 16 '17 15:05 coveralls

Hi @tocalvo!

Thanks for this pull request. I'll test this on all operating systems and with all the boards I have and let you know. Won't get to this until the weekend, apologies.

I also aim to look at your stk500v1 pull request also, apologies for the lag! I've had a tonne of travel the last month 🙇‍♀️

noopkat avatar May 17 '17 22:05 noopkat

just an update - I tested 90% of the boards on macOS and they're great. I'll now test on Windows and Linux but it's looking good so far!

noopkat avatar May 21 '17 16:05 noopkat

Thank you so much for your time and patience!! 😄 I'll wait, no problem. If i can help you in any way, just tell me.

tocalvo avatar May 21 '17 16:05 tocalvo

bump

nandub avatar Jun 15 '18 05:06 nandub