noobaa-operator icon indicating copy to clipboard operation
noobaa-operator copied to clipboard

Adding secretef Webhook For Backingstore and Namespacestore

Open liranmauda opened this issue 3 years ago • 1 comments

Explain the changes

  • Adding secretef Webhook For Backingstore and Namespacestore to validate that it has namespace in it.

Closing the gap from #914

Signed-off-by: liranmauda [email protected]

Issues:

  1. Fixed https://bugzilla.redhat.com/show_bug.cgi?id=2084201

Testing Instructions:

  1. Try to apply a backingstore without a namespace in its secretef
  2. Try to update backingstore to remove the namespace from its secretef
  3. Do the above steps on a namespacestore.
  • [ ] Tests added

liranmauda avatar May 30 '22 13:05 liranmauda

@dannyzaken @kfir-payne please take a look. The PR is in draft so we can look at its logic, once we think it is ok, I will add tests and remove from draft.

liranmauda avatar May 30 '22 13:05 liranmauda

@liranmauda I think that for now we can skip the webhook validation for that. let's close

dannyzaken avatar Oct 25 '22 08:10 dannyzaken

@liranmauda I think that for now we can skip the webhook validation for that. let's close

Closing.

liranmauda avatar Oct 25 '22 08:10 liranmauda