noobaa-operator icon indicating copy to clipboard operation
noobaa-operator copied to clipboard

Published 20 hours ago • verified publisher icon noobaa

Why did we set phase Ready of modes that were not mapped?

Open shirady opened this issue 2 years ago • 1 comments

Inside the reconciler of backingstore we have modeInfoMap. https://github.com/noobaa/noobaa-operator/blob/d821724e89d182e69ef05c7c533398c9c4a5241c/pkg/backingstore/reconciler.go#L48-L67

inside the function completeReconcile we set the phase Ready to modes that were not mapped in modeInfoMap. https://github.com/noobaa/noobaa-operator/blob/d821724e89d182e69ef05c7c533398c9c4a5241c/pkg/backingstore/reconciler.go#L224-L231

The open questions are:

  1. Why did we choose to set the phase as Ready?
  2. Is there a reason that we will not map explicitly all the modes from core inside modeInfoMap?

shirady avatar Feb 22 '23 16:02 shirady