noobaa-core
noobaa-core copied to clipboard
Change upload object ID encoding to hex on Azure blob backend
Explain the changes
- change the encoding of object ID from base64 to hex
Issues: Fixed #xxx / Gap #xxx
- WinSCP's implementation of S3 does not support base64 encoded upload IDs as it does not urlencode the ID correctly, when it contains '/', '+', '='. using hex solves this
- also the etag, which is hex-encoded, is used as upload ID in the noobaa namespaced s3 implementation
Testing Instructions:
- start noobaa with a namespaced azure blob backend
- use WinSCP to upload multiple objects
- => some of the uploads fail, but if you retry often enough every object can be uploaded. this is due to the base64 encoding of the upload ID sometimes contain the characters mentioned above
i know this technically isn't a noobaa bug but we want our external customers to be able to use WinSCP with noobaa and patching WinSCP is not really an option:/ i would greatly appreciate it if you could still merge it!
This PR is over a year old, if still relevant please rebase and reopen