noobaa-core icon indicating copy to clipboard operation
noobaa-core copied to clipboard

quick fix for create triggers not working with namespaced bucket #6575 [draft]

Open lallinger-tech opened this issue 3 years ago • 3 comments

Explain the changes

  1. Quick implementation for missing create triggers on namespaced buckets

Issues: Fixed #xxx / Gap #xxx

  1. #6575
  2. Only fixes ObjectCreated triggers on simple upload and multipart upload

Testing Instructions:

  1. Create function
  2. Create bucket
  3. Add ObjectCreated trigger with function to trigger
  4. Upload object to bucket, which fires trigger
  5. Verify trigger was called

lallinger-tech avatar Jun 18 '21 10:06 lallinger-tech

Hi @lallinger-arbeit Thanks for this PR, I have written some comments. Once they are done, you need to sign the commit in order to resolve the DCO. regarding the fail tests, they are lint errors, but the changes I asked for should resolve them. If there will be another lint error we will resolve them too.

liranmauda avatar Jun 20 '21 07:06 liranmauda

Hi @lallinger-arbeit Thanks for this PR, I have written some comments. Once they are done, you need to sign the commit in order to resolve the DCO.

Hi @liranmauda as discussed in the community meeting this is just my quick and dirty implementation, and should only be seen as draft, which does not need to get merged. I think it is best you implement the neccessary changes for all the triggers, so also ObjectRead and ObjectRemoved, as you have way deeper insight in the code. And also it is not a problem for us if it takes a few weeks, as this implementation is currently working for our use case

lallinger-tech avatar Jun 21 '21 11:06 lallinger-tech

Hi @liranmauda as discussed in the community meeting this is just my quick and dirty implementation, and should only be seen as draft, which does not need to get merged. I think it is best you implement the neccessary changes for all the triggers, so also ObjectRead and ObjectRemoved, as you have way deeper insight in the code. And also it is not a problem for us if it takes a few weeks, as this implementation is currently working for our use case

This is a great PR, And we can marge it after we address the changes above. We will probably do the same + adding the missing parts.

liranmauda avatar Jun 22 '21 08:06 liranmauda