noobaa-core icon indicating copy to clipboard operation
noobaa-core copied to clipboard

Dedup did not work fully when uploaded same file 4 times

Open jeniawhite opened this issue 7 years ago • 5 comments

Environment info

  • Version: output of git rev-parse HEAD | package.json | UI
  • Deployment: N/A | Dev | VBox | ESX | GCloud | AWS
  • Customer: N/A | QA | name

Actual behaviour

  • Created a new bucket with policy of 1 pool with 3 nodes (all okay)
  • Uploaded 3mb file (not video/no special replicas) that created 6 parts
  • Waited that everything replicated correctly and that the blocks/chunks/parts are accessible
  • Uploaded same file ones again with a different name
  • Waited that everything replicated correctly and that the blocks/chunks/parts are accessible
  • Saw in DB that there was a full dedup (everything correct till now)
  • Uploaded same file ones again with a different name
  • Waited that everything replicated correctly and that the blocks/chunks/parts are accessible
  • Saw in DB that we created 6 more chunks which means that we did not dedup 0%
  • Afterwards did same thing with the 4th file and got a 100% dedup

Expected behavior

  1. I should see 100% all of the time and only have 6 chunks (like parts count of the first file)

Steps to reproduce

  1. Explained above

Screenshots or Logs or other output that would be helpful

(If large, please upload as attachment)

jeniawhite avatar Nov 10 '16 10:11 jeniawhite

@nimrod-becker This is too old and stale by now. We should either reproduce on master or close.

guymguym avatar Feb 04 '18 10:02 guymguym

Reproduced by Liran

nimrod-becker avatar Feb 07 '18 08:02 nimrod-becker

I will add a unit test that writes same file repeatedly and verifies that it always finds dedup.

guymguym avatar Mar 27 '18 11:03 guymguym

Per guy's comment, closing this one

nimrod-becker avatar Mar 27 '18 11:03 nimrod-becker

Keeping open as a reminder to commit the test

guymguym avatar Mar 27 '18 15:03 guymguym