gpt4all icon indicating copy to clipboard operation
gpt4all copied to clipboard

[Feature] Wayland Support

Open furretgd1 opened this issue 9 months ago • 8 comments

Feature Request

Implement Wayland support as when building or trying to run the binary release with Wayland support fails.

furretgd1 avatar May 05 '24 04:05 furretgd1

upstream issue: https://github.com/probonopd/linuxdeployqt/issues/189 upstream PR: https://github.com/probonopd/linuxdeployqt/pull/540

cebtenzzre avatar May 05 '24 04:05 cebtenzzre

Just for sake of completion, this is the error message I get on Nobara 40 trying to compile 1ce65e8ef287a80c19db010a86f1113f4a1148f4, which is a Fedora based distribution:

[cmake] Führe /usr/bin/cmake -S /home/thilo/Prog/Development/GPT4All_Nomic.AI_GPT4All/gpt4all/gpt4all-chat -B /home/thilo/Prog/Development/GPT4All_Nomic.AI_GPT4All/gpt4all/gpt4all-chat/build/Desktop-Release in /home/thilo/Prog/Development/GPT4All_Nomic.AI_GPT4All/gpt4all/gpt4all-chat/build/Desktop-Release aus.
[cmake] -- Could NOT find Wayland_Client (missing: Wayland_Client_LIBRARY Wayland_Client_INCLUDE_DIR) (found version "")
[cmake] -- Could NOT find Wayland_Server (missing: Wayland_Server_LIBRARY Wayland_Server_INCLUDE_DIR) (found version "")
[cmake] -- Could NOT find Wayland_Cursor (missing: Wayland_Cursor_LIBRARY Wayland_Cursor_INCLUDE_DIR) (found version "")
[cmake] -- Could NOT find Wayland_Egl (missing: Wayland_Egl_LIBRARY Wayland_Egl_INCLUDE_DIR Wayland_Client_FOUND) (found version "")
[cmake] -- Could NOT find Wayland (missing: Wayland_LIBRARIES) (Required is at least version "1.15")
[cmake] CMake Warning at /usr/lib64/cmake/Qt6/Qt6Config.cmake:179 (find_package):
[cmake]   Found package configuration file:
[cmake] 
[cmake]     /usr/lib64/cmake/Qt6WaylandCompositor/Qt6WaylandCompositorConfig.cmake
[cmake] 
[cmake]   but it set Qt6WaylandCompositor_FOUND to FALSE so package
[cmake]   "Qt6WaylandCompositor" is considered to be NOT FOUND.  Reason given by
[cmake]   package:
[cmake] 
[cmake]   Qt6WaylandCompositor could not be found because dependency Wayland could
[cmake]   not be found.
[cmake] 
[cmake]   Configuring with --debug-find-pkg=Wayland might reveal details why the
[cmake]   package was not found.
[cmake] 
[cmake]   Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
[cmake]   of the path variables that find_package uses to try and find the package.
[cmake] 
[cmake] Call Stack (most recent call first):
[cmake]   CMakeLists.txt:47 (find_package)
[cmake] 
[cmake] 
[cmake] -- Configuring incomplete, errors occurred!
[cmake] CMake Error at CMakeLists.txt:47 (find_package):
[cmake]   Found package configuration file:
[cmake] 
[cmake]     /usr/lib64/cmake/Qt6/Qt6Config.cmake
[cmake] 
[cmake]   but it set Qt6_FOUND to FALSE so package "Qt6" is considered to be NOT
[cmake]   FOUND.  Reason given by package:
[cmake] 
[cmake]   Failed to find required Qt component "WaylandCompositor".
[cmake] 
[cmake]   Expected Config file at
[cmake]   "/usr/lib64/cmake/Qt6WaylandCompositor/Qt6WaylandCompositorConfig.cmake"
[cmake]   exists
[cmake] 
[cmake] 
[cmake] 
[cmake]   Configuring with --debug-find-pkg=Qt6WaylandCompositor might reveal details
[cmake]   why the package was not found.
[cmake] 
[cmake]   Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
[cmake]   of the path variables that find_package uses to try and find the package.
[cmake] 
[cmake] 
[cmake] 
[cmake] 
[cmake] Das Kommando "/usr/bin/cmake -S /home/thilo/Prog/Development/GPT4All_Nomic.AI_GPT4All/gpt4all/gpt4all-chat -B /home/thilo/Prog/Development/GPT4All_Nomic.AI_GPT4All/gpt4all/gpt4all-chat/build/Desktop-Release" wurde beendet, Rückgabewert 1.
[cmake] 
[cmake] Verstrichene Zeit: 00:00.

ThiloteE avatar Jul 03 '24 15:07 ThiloteE

Why not just use flatpak. Better anyway and you dont have to deal with @probonopd

CodeMystic21 avatar Aug 21 '24 21:08 CodeMystic21

Flatpak support is tracked here: https://github.com/nomic-ai/gpt4all/issues/698#issuecomment-2171275609

ThiloteE avatar Aug 22 '24 09:08 ThiloteE

@probonopd wrote:

pardon?

What do you mean pardon.? Just look at this issues title.

Your are blocking a very simple wayland fix for years. Even if it would not have any downsides for non wayland user (if you are for some not understandble reqson). (Dont tell me about the like 1mb size increase actually matters ...

There are people like me that don't want and insecure system with legacy decades old x11 no one wants to maintain anymore. And still using long deprecated fuse2, which does not get patched anymore.

CodeMystic21 avatar Aug 22 '24 19:08 CodeMystic21

I am not blocking any fixes in Wayland. I am just not adding anything Wayland specific to my own tools, because I am not running Wayland and hence cannot test nor support it.

There are many different tools that can deploy applications in the AppImage format, there is no need to use mine if they don't satisfy your needs.

probonopd avatar Aug 23 '24 16:08 probonopd

linuxdeploy (different from linuxdeployqt) has a Qt plugin with Wayland support, it seems like it was added here.

cebtenzzre avatar Aug 23 '24 22:08 cebtenzzre

I am not blocking any fixes in Wayland. I am just not adding anything Wayland specific to my own tools, because I am not running Wayland and hence cannot test nor support it.

I can understand not wanting to do the work yourself, but not accepting a very simple pr is "blocking" for me. Lets don't play word pickery.

But I dont care then, if flatpak support is on the roadmap. Has better Desktopintegration / theming, sandboxing, dbus, portals,... support anyway.

But lets stop discussing here on some random projects issue

CodeMystic21 avatar Aug 25 '24 21:08 CodeMystic21