deepscatter icon indicating copy to clipboard operation
deepscatter copied to clipboard

label_click and other interaction handlers should pass the event info

Open RLesser opened this issue 1 year ago • 2 comments

Currently the interaction handler only has the record data as available arguments. It should also have the Event spawned by the interaction. This will let us do different behaviors for shift.

RLesser avatar Jan 31 '24 20:01 RLesser

concretely, the minimal-impact way to handle this will be to take the SettableFunction class of this type:

  abstract default(datum: ArgType, plot: Scatterplot<Tiletype> | undefined): FuncType;

and convert them all to this type

  abstract default(datum: ArgType, plot: Scatterplot<Tiletype> | undefined, event : Event): FuncType;

...ensuring that all the handlers under the hood actually do pass their spawning events along the other two args.

bmschmidt avatar Jan 31 '24 21:01 bmschmidt

hey @bmschmidt,

Was looking to make my first contribution to the project. Can I take this up?

cloud-shannon avatar Feb 14 '24 00:02 cloud-shannon