gipeda icon indicating copy to clipboard operation
gipeda copied to clipboard
verified publisher icon nomeata

Missing revision summaries in graph view

Open stephg opened this issue 9 years ago • 3 comments

It happens that the graph view does not load successfully and I get a JS error at gipeda.js:130 and I can see that the revision lacks summary information. Looks like not all summaries are loaded from disk?

When I change gipeda.js:81 to all-summaries.json instead of latest-summaries.json, graphs load as exepected.

stephg avatar May 18 '16 07:05 stephg

What is the JS error? Can you maybe attach latest-summaries.json and all-summaries.json? Or even better, have a look at these files and see what might be missing in latest-summaries.json.

nomeata avatar May 18 '16 07:05 nomeata

The error is Uncaught TypeError: Cannot read property 'parents' of undefined commitsFrom @ gipeda.js:130.

I had a look at both json files. Content look good, all revisions of latest-summaries.json are in all-summaries.json too and summary object is filled as expected.

But, there are 51 Revisions in latest-summaries.json and 91 in all-summaries.json and my gipeda.xml contains limitRecent: 80. When readjusting this value to 50, all is fine.

stephg avatar May 18 '16 09:05 stephg

Ah, right. This limitRecent is somewhat buggy, see #29. In particular, it is hardcoded to 50 in some places in gipeda.

nomeata avatar May 18 '16 10:05 nomeata