react-mosaic icon indicating copy to clipboard operation
react-mosaic copied to clipboard

Published 20 hours ago • verified publisher icon nomcopter

Bundle cjs and esm

Open Lonli-Lokli opened this issue 9 months ago • 2 comments

Fixes #193

Changes proposed in this pull request: Bundle both cjs and esm making a few changes as possible.

Reviewers should focus on: Confirming the new bundle works in both cjs and esm projects.

Lonli-Lokli avatar May 10 '24 17:05 Lonli-Lokli

In order to make thigs work with both Node and browser I have to add tsup. Also it was too difficult to update and make mocha+chai work with new module so test framework has been changed to vitest.

Additionally lodash deps has been changed to ESM dependency and updated imports to make it work in ESM

Lonli-Lokli avatar Sep 10 '24 08:09 Lonli-Lokli

Also I had to disable tslint because it was complaining (prettier) about both CR/CRLF. It was again non-fixable in reasonable time. Can you consider migrating to eslint and run prettier on commit ?

Lonli-Lokli avatar Sep 10 '24 09:09 Lonli-Lokli