nomad-monorepo icon indicating copy to clipboard operation
nomad-monorepo copied to clipboard

Use `*_contracts.json` files to populate the sdk

Open prestwich opened this issue 3 years ago • 2 comments

@kekonen requested that we add xappconnectionmanagers to the SDK contracts objects.

The way I’d prefer to do it is taking the deploy’s *_contracts.json files as an input to SDK context instantiation, that we go ahead and get all nomad contracts without having to manually copy+paste contract addresses

so the set of changes I’d prefer is something like:

  • create a root level deploys/ folder
  • move the *_contracts.json files to deploys/
  • have the deploy process output future *_contracts.json to deploys/whatever
  • have the build process for the sdk copy files from deploys/ to typescript/sdk/nomad/domains/deploys/
  • have the sdk load all the json
  • ensure the sdk packaging copys those json to dist and includes them in the published package

cc @anna-carroll for sanity checking and deploy-code changes

in the meantime, @kekonen should go ahead and add the connection manager manually

prestwich avatar Jan 13 '22 17:01 prestwich

sounds great to me 🌷

anna-carroll avatar Jan 13 '22 19:01 anna-carroll

This relates to #69, both issues discuss alternative approaches to smoothing out configuration in the monorepo.

yourbuddyconner avatar Jan 25 '22 21:01 yourbuddyconner