dom7 Do these lines need to be deleted?

Do these lines need to be deleted?

Open DAnn2012 opened this issue 4 years ago • 3 comments

@nolimits4web Do these lines need to be deleted?

https://github.com/nolimits4web/dom7/blob/925718340f89d480c04fa50a86844822b534099c/src/%24.js#L46

https://github.com/nolimits4web/dom7/blob/925718340f89d480c04fa50a86844822b534099c/src/scroll.js#L92

Thanks.

Jul 22 '21 13:07 DAnn2012

Not necessary as these comment don't affect anything

Jul 22 '21 15:07 nolimits4web

@nolimits4web I understand, but it was because in this way they are also reported in this files:

https://github.com/nolimits4web/dom7/blob/925718340f89d480c04fa50a86844822b534099c/package/dom7.js#L379

https://github.com/nolimits4web/dom7/blob/925718340f89d480c04fa50a86844822b534099c/package/dom7.js#L1612

https://github.com/nolimits4web/dom7/blob/925718340f89d480c04fa50a86844822b534099c/package/dom7.esm.js#L221

https://github.com/nolimits4web/dom7/blob/925718340f89d480c04fa50a86844822b534099c/package/dom7.esm.js#L1394

and also in this framework7 files (Lines 393-1562):

https://unpkg.com/browse/[email protected]/framework7-bundle.js

https://unpkg.com/browse/[email protected]/framework7.js

Thanks.

Jul 22 '21 21:07 DAnn2012

Yes, but anyway it is still doesn't affect anything :) PR is welcome if it bothers you

Jul 23 '21 08:07 nolimits4web