Nolan Lawson
Nolan Lawson
Another issue with the current approach is that Firefox shows mixed fonts; e.g. in the first screenshot above, "shaking face" (🫨) is rendering with Noto Color since it comes from...
Reopening as native custom element lifecycle had to be reverted in the Salesforce Lightning Platform due to breaking changes, although it is still rolled out for pure OSS consumers.
Thanks for opening the issue. FWIW there are multiple places this would also have to be changed: - LWR - lwc-test - lwc-platform - lwc-webpack-plugin
Is this an issue in `engine-dom` as well?
BTW I'm not 100% sold on this (due to the complexity/accessibility issues), but it's definitely worth considering.
Thank you for reporting! This is a known issue: https://github.com/salesforce/eslint-config-lwc/issues/128
We already have `es-module-lexer` which can be used for this.
Yeah the idea is: 1. Use `es-module-lexer` to crawl the module graph 2. Run `@lwc/compiler` directly on each file instead of `@lwc/rollup-plugin` There is a case to be made that...
I don't understand. Don't we have tests here to confirm that there are no unused import warnings? https://github.com/salesforce/lwc/blob/2d11a5b0b18b3bbffaa412d5d3003ecff5be14d2/packages/%40lwc/ssr-compiler/src/__tests__/fixtures.spec.ts#L60-L69
Potential fix: we could use a `VFragment` for `for:each`. This may help the vdom diffing to distinguish between different `for:each` blocks.