resources Add full support for AMD NPUs

Is there an existing issue for this?

[X] I have searched the existing issues

Is your feature request related to a problem? Please describe.

Right now, there's support for Intel and Rockchip NPUs, but for AMD NPUs there's no graph

Describe the solution you'd like

Support for AMD NPUs and their stats, likely using the AMD XDNA Driver

Current behavior:

Dec 10 '24 06:12 ThatOneCalculator

Hi, thanks for the issue. If the amdxdna driver exposes utilization information, I'll try to implement support for it. :)

Dec 10 '24 12:12 nokyan

xdna-driver supports drm usage stats (fdinfo).

https://github.com/amd/xdna-driver/pull/262

Dec 10 '24 23:12 Umio-Yasuno

xdna-driver supports drm usage stats (fdinfo).

I don't think that supports temps, power usage, etc, but that's good to know!

Also, unless I'm doing something wrong, it seems like memory and usage isn't reported at all, or at least incorrectly.

Opening /dev/accel/accel0...
Got fd: 4

Trying to read DRM stats from /proc/self/fdinfo/4:
  drm-driver:    amdxdna_accel_driver
  drm-client-id:    76
  drm-pdev:    0000:c5:00.1
  drm-engine-npu-amdxdna:    0 ns
  drm-total-memory:    0
  drm-shared-memory:    0
  drm-active-memory:    0

use std::{fs::File, io::{BufRead, BufReader}, os::fd::AsRawFd};

fn main() {
    println!("Opening /dev/accel/accel0...");
    match File::open("/dev/accel/accel0") {
        Ok(f) => {
            let fd = f.as_raw_fd();
            println!("Got fd: {}", fd);
            
            println!("\nTrying to read DRM stats from /proc/self/fdinfo/{}:", fd);
            match File::open(format!("/proc/self/fdinfo/{}", fd)) {
                Ok(fdinfo) => {
                    let reader = BufReader::new(fdinfo);
                    for line in reader.lines().flatten() {
                        if line.starts_with("drm-") {
                            println!("  {}", line);
                        }
                    }
                }
                Err(e) => println!("Error opening fdinfo: {}", e),
            }
        }
        Err(e) => println!("Error opening device: {}", e),
    }
}

Dec 11 '24 01:12 ThatOneCalculator

xdna-driver supports drm usage stats (fdinfo).

I don't think that supports temps, power usage, etc, but that's good to know!

Also, unless I'm doing something wrong, it seems like memory and usage isn't reported at all, or at least incorrectly.

Opening /dev/accel/accel0...
Got fd: 4

Trying to read DRM stats from /proc/self/fdinfo/4:
  drm-driver:    amdxdna_accel_driver
  drm-client-id:    76
  drm-pdev:    0000:c5:00.1
  drm-engine-npu-amdxdna:    0 ns
  drm-total-memory:    0
  drm-shared-memory:    0
  drm-active-memory:    0

use std::{fs::File, io::{BufRead, BufReader}, os::fd::AsRawFd};

fn main() {
    println!("Opening /dev/accel/accel0...");
    match File::open("/dev/accel/accel0") {
        Ok(f) => {
            let fd = f.as_raw_fd();
            println!("Got fd: {}", fd);
            
            println!("\nTrying to read DRM stats from /proc/self/fdinfo/{}:", fd);
            match File::open(format!("/proc/self/fdinfo/{}", fd)) {
                Ok(fdinfo) => {
                    let reader = BufReader::new(fdinfo);
                    for line in reader.lines().flatten() {
                        if line.starts_with("drm-") {
                            println!("  {}", line);
                        }
                    }
                }
                Err(e) => println!("Error opening fdinfo: {}", e),
            }
        }
        Err(e) => println!("Error opening device: {}", e),
    }
}

fdinfo is per-process information.
A full scan of /proc can give you a rough idea of overall usage.

The result itself is probably correct.

Dec 11 '24 03:12 Umio-Yasuno

Do you mind trying out the amdxdna-support branch?

Dec 14 '24 18:12 nokyan

Unfortunately usage doesn't seem to work, but it now shows "0%" instead of N/A

npu_resources_test.webm

Dec 14 '24 20:12 ThatOneCalculator

Do you mind sending me debug logs (run resources with the environment variable RUST_LOG=resources=debug set)?

Dec 14 '24 21:12 nokyan

Here's the logs with some extraneous stuff (like associated processes/finding apps) removed:

 DEBUG resources::utils > Running as Flatpak
 INFO  resources::application > Resources (net.nokyan.Resources.Devel)
 INFO  resources::application > Version: 1.7.1-amdxdna-support/d7a7f15
 INFO  resources::application > Datadir: /app/share/resources
 DEBUG resources::application > Operating system: Arch Linux
 DEBUG resources::application > Kernel version: 6.13.0-rc2-1-mainline-um5606-dirty
 INFO  resources::application > You are running a development version of Resources, things may be slow or break!
Fontconfig error: Cannot load config file "/run/host/font-dirs.xml": No such file: /run/host/font-dirs.xml

(resources:2): Gtk-WARNING **: 13:06:10.827: Unable to acquire the address of the accessibility bus: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown. If you are attempting to run GTK without a11y support, GTK_A11Y should be set to 'none'.
 DEBUG resources::utils::gpu  > Searching for GPUs…
 DEBUG resources::utils::pci  > Parsing pci.ids…
 INFO  resources::utils::pci  > Successfully parsed pci.ids within 11.31ms (vendors: 2406, devices: 19158, subdevices: 16665)
 DEBUG resources::utils::gpu::amd > Parsing /run/host/usr/share/libdrm/amdgpu.ids…
 DEBUG resources::utils::gpu::amd > Successfully parsed /run/host/usr/share/libdrm/amdgpu.ids within 792.30µs (573 entries)
 INFO  resources::utils::gpu      > Found GPU "AMD Radeon Graphics (Strix [Radeon 880M / 890M])" (PCI slot: 0000:c4:00.0 · PCI ID: 1002:150e · Category: AMD)
 DEBUG resources::utils::gpu      > 1 GPUs found
 DEBUG resources::utils::app      > Detecting installed apps
 DEBUG resources::utils::app      > Using the following directories for app detection: ["/app/share/applications", "/usr/share/applications", "/usr/share/runtime/share/applications", "/run/host/user-share/applications", "/run/host/usr/share/applications", "/run/host/share/applications", "/app/local/share/applications", "/usr/local/share/applications", "/usr/local/share/runtime/share/applications", "/run/host/usr/local/share/applications", "/run/host/local/share/applications", "/var/lib/flatpak/exports/share/applications", "/home/kainoa/.local/share/flatpak/exports/share/applications", "/var/lib/snapd/desktop/applications", "/home/kainoa/.local/share/applications"]
 DEBUG resources::utils::app      > Using the following locales for app names and descriptions: ["en_US.utf8", "en_US", "en"]
 INFO  resources::utils::app      > Detected 322 apps within 21.71ms
 DEBUG resources::utils::memory   > Memory information obtained using udevadm
 DEBUG resources::utils::npu      > Searching for NPUs…
 INFO  resources::utils::npu      > Found NPU "Strix Neural Processing Unit" (PCI slot: 0000:c5:00.1 · PCI ID: 1022:17f0 · Category: AMD)
 DEBUG resources::utils::npu      > 1 NPUs found
 DEBUG resources::utils::cpu      > CPU temperature sensor located at /sys/class/hwmon/hwmon6/temp1_input (k10temp)
 DEBUG resources::utils::process  > Spawning resources-processes in Flatpak mode (/home/kainoa/Downloads/resources/.flatpak-builder/rofiles/rofiles-78ArUe/files/libexec/resources/resources-processes)
 DEBUG resources::utils::app      > Associating process 3000729 with app "Resources" (ID: "net.nokyan.Resources.Devel") based on process cgroup matching with app ID
 DEBUG resources::utils::app      > Associating process 3000748 with app "Resources" (ID: "net.nokyan.Resources.Devel") based on process cgroup matching with app ID
 DEBUG resources::utils::app      > Associating process 3000749 with app "Resources" (ID: "net.nokyan.Resources.Devel") based on process cgroup matching with app ID
 DEBUG resources::utils::app      > Associating process 3000752 with app "Resources" (ID: "net.nokyan.Resources.Devel") based on process cgroup matching with app ID
 DEBUG resources::utils::app      > Associating process 3000753 with app "Resources" (ID: "net.nokyan.Resources.Devel") based on process cgroup matching with app ID
 DEBUG resources::utils::app      > Associating process 3000802 with app "Resources" (ID: "net.nokyan.Resources.Devel") based on process cgroup matching with app ID
 DEBUG resources::utils::app      > Associating process 3000806 with app "Resources" (ID: "net.nokyan.Resources.Devel") based on match in KNOWN_EXECUTABLE_NAME_EXCEPTIONS
 INFO  resources::ui::window      > A drive has been added (or turned visible): /sys/block/nvme0n1
 INFO  resources::ui::window      > A network interface has been added (or turned visible): /sys/class/net/wlan0
 INFO  resources::ui::window      > A battery has been added: /sys/class/power_supply/BAT0

(resources:2): Gdk-WARNING **: 13:06:11.847: vkAcquireNextImageKHR(): A swapchain no longer matches the surface properties exactly, but can still be used to present to the surface successfully. (VK_SUBOPTIMAL_KHR) (1000001003)

Dec 14 '24 21:12 ThatOneCalculator

In the folder where you've pulled this repo to, there's probably a folder called ".flatpak" or "flatpak_app", within its subfolders should be a binary called "resources-processes" (for me it's ".flatpak/repo/libexec/resources-processes", but I'm using VSCode to build it), can you run this binary with the following arguments resources-processes -o -r and send the output (preferably excerpts with the field "npu_usage_stats" not empty, the output will be very large)? Double-check that there's no personally identifiable data like names in there.

Dec 14 '24 21:12 nokyan

Interestingly, I get a lot of gpu_usage_stats outputs but no npu_usage_stats outputs, even when running the resources-processes command while running the XDNA NPU example.

Also, for me the binary is located in .flatpak/repo/files/libexec/resources/resources-processes

Dec 14 '24 21:12 ThatOneCalculator

Interestingly, I get a lot of gpu_usage_stats outputs but no npu_usage_stats outputs, even when running the resources-processes command while running the XDNA NPU example

Yeah, I've just noticed too that there is a bug where resources-processes doesn't differentiate between NPU usage and GPU usage.

Dec 14 '24 21:12 nokyan

Do you want me to send all the gpu_usage_stats or just wait?

Dec 14 '24 21:12 ThatOneCalculator

Do you want me to send all the gpu_usage_stats or just wait?

Give me a couple of minutes (hopefully), I'll notify you. :)

Dec 14 '24 21:12 nokyan

@ThatOneCalculator You can pull and try again :)

Dec 14 '24 21:12 nokyan

I can't seem to find where it actually says "npu_usage" :thinking:

Dec 14 '24 21:12 ThatOneCalculator

I can't seem to find where it actually says "npu_usage" 🤔

That's quite odd, I don't have an NPU though lots of empty npu_usage_stats fields Though the "binary file matches" stuff happens because the first four bytes is the length of the following content in binary, Resources needs that. You just removed those first four bytes in vSCode I assume?

Dec 14 '24 21:12 nokyan

You just removed those first four bytes in vSCode I assume?

I just opened it as a text file in vscode, and it showed the normal logs after a little bit of unicode

Dec 14 '24 21:12 ThatOneCalculator

You just removed those first four bytes in vSCode I assume?

I just opened it as a text file in vscode, and it showed the normal logs after a little bit of unicode

Can you send me a screenshot or excerpt of one process with gpu_usage_stats or npu_usage_stats not empty, like this?

    (
        pid: 149834,
        parent_pid: 149833,
        user: "nokyan",
        comm: "loupe",
        commandline: "/app/bin/loupe\0--gapplication-service\0",
        user_cpu_time: 35,
        system_cpu_time: 16,
        niceness: (0),
        affinity: [
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
        ],
        memory_usage: 25403392,
        swap_usage: 0,
        starttime: 1687313,
        cgroup: Some("org.gnome.Loupe"),
        containerization: Flatpak,
        read_bytes: Some(102400),
        write_bytes: Some(663552),
        timestamp: 1734211947096,
        gpu_usage_stats: {
            (
                domain: 0,
                bus: 45,
                number: 0,
                function: 0,
            ): (
                gfx: 66823570,
                mem: 35753984,
                enc: 0,
                dec: 0,
                nvidia: false,
            ),
        },
        npu_usage_stats: {},
    )

Dec 14 '24 21:12 nokyan

    (
        pid: 3033353,
        parent_pid: 2193,
        user: "kainoa",
        comm: "firefox",
        commandline: "/usr/lib/firefox/firefox\0",
        user_cpu_time: 7622,
        system_cpu_time: 1780,
        niceness: (0),
        affinity: [
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
            true,
        ],
        memory_usage: 251604992,
        swap_usage: 0,
        starttime: 10243378,
        cgroup: Some("firefox"),
        containerization: None,
        read_bytes: Some(39702528),
        write_bytes: Some(278487040),
        timestamp: 1734212614309,
        gpu_usage_stats: {
            (
                domain: 0,
                bus: 196,
                number: 0,
                function: 0,
            ): (
                gfx: 6470733323,
                mem: 254169088,
                enc: 0,
                dec: 0,
                nvidia: false,
            ),
        },
    ),