Takahiro Yamashita

Results 134 comments of Takahiro Yamashita

@edsiper #8491 is for `MESSAGE` and this patch is for `METADATA`. They are different feature. By the way I think it is better that the default value of `logs_*_metadata_key` is...

@braydonk Could you check this PR ? This patch is to set a value for OTLP from metadata. As you know https://github.com/fluent/fluent-bit/pull/8294 is to store OTLP field as metadata of...

@cb645j This patch is to get a value from `METADATA` and set as a value of OTLP. It is not for `MESSAGE`. https://docs.fluentbit.io/manual/concepts/key-concepts#event-format There are some points to discuss. 1....

@cb645j Thank you for information. Currently this patch can't solve your issue. It may be better to support properties for MESSAGE like `logs_trace_id_message_key` you suggested. But It needs a lot...

@cb645j The type of TraceId and SpanId are byte sequence. String will be ignored since the data type is different. https://opentelemetry.io/docs/specs/otel/logs/data-model/#field-traceid https://opentelemetry.io/docs/specs/otel/logs/data-model/#field-spanid

Could you check the forward protocol specification v1.5 ? https://github.com/fluent/fluentd/wiki/Forward-Protocol-Specification-v1.5#event-modes

Thank you for reporting. I sent a patch https://github.com/fluent/fluent-bit/pull/8474 .

@braydonk Could you check/test this PR since it relates https://github.com/fluent/fluent-bit/issues/8205 ? This patch is to save "resource" field of logs. However I don't have a tool to send it.

@braydonk Thank you for information and comment. I can test using `otelcol-contrib` and output is here. We can see fluent-bit saves attributes of resource and logRecords as a metadata. Output...

@braydonk Thank you for comment. I tried to modify metadata structure like hierarchical OTLP payload. This patch was to prevent breaking changes for metadata structure, so I ignored OTLP hierarchy....