Takahiro Yamashita

Results 134 comments of Takahiro Yamashita

Monkey is 1.7.0. I used 62f1aa2f01c0e5b668bd3a1b58ab1db4a1460be7 (as you know, you fixed unknown type name 'ucontext_t' problem.) It contains commit 563307d5bc8f5b35231cf41ea5be2fa5d7210a24. I built with these commands. ``` sh $ sh ./configure...

No, I only shared my environmental information.(libexecinfo.so/a are already installed.) I have no idea to fix this issue, but it seems to be environment-dependent. So, I want to provide environmental...

@edsiper @leonardo-albertovich ping.

I think `mk_list_is_empty` returns 0 if the list is empty. (I think it is not intuitive.) https://github.com/monkey/monkey/blob/master/include/monkey/mk_core/mk_list.h#L100 Should we check if `mk_list_is_empty(head) == 0` ? ```c static inline void mk_list_append(struct...

Thank you for reviewing. I'll add below functions. ```c static inline void mk_list_append(struct mk_list *_new, struct mk_list *head) { if (mk_list_is_empty(head) == 0) { __mk_list_add(_new, head->prev, head); } else {...

I added `mk_list_append/prepend` functions.

Thank you for comment. I wait for the work to be done. > leonardo-coroutine-scheduler-improvement-wip Is there any draft pull request ? I prefer a pull request if I'll review/add a...

https://github.com/monkey/monkey/pull/357/commits/b4007ddaf61cddc4235cf95f49ae4fec8380ba3c is to send `MK_SERVER_SIGNAL_STOP` twice (same fd and same value) and I think it introduces invalid read. Below diff prevents leak. It is to send `MK_SERVER_SIGNAL_STOP` just once. ```diff...

I merged the patch https://github.com/fluent/fluent-bit/pull/3908 @gautampunhani Thank you.

I think it is better to add RWMutex for prevention. In my understanding, a lock is taken care on C side. https://fluentbit.io/announcements/v1.7.0/ ``` The multithread implementation is lock-free at runtime....