adcs-issuer icon indicating copy to clipboard operation
adcs-issuer copied to clipboard

Is this project alive?

Open stanislaw55 opened this issue 4 years ago • 7 comments

Hi, I just want to ask about this project status. https://github.com/jetstack/cert-manager/issues/2288 is already merged in cert-manager and README is not updated yet. Also, I haven't seen any new development recently

stanislaw55 avatar Jun 26 '20 12:06 stanislaw55

seems to be stopped, 7months of no activity. I've forked the repo a while ago and made it working. You can check it out. Will create a PR, when I'm finished.

SimeonPoot avatar Jul 30 '20 14:07 SimeonPoot

Hi @SimeonPoot, thanks for answer. I definitely take a look.

stanislaw55 avatar Aug 03 '20 10:08 stanislaw55

I've just yesterday got your fork working within my EKS cluster. I had a serious problem of infinite looping when using cert-manager 1.16.0 helm chart, but after upgrade to 1.16.1 all is good...thanks much.

makeacode avatar Aug 26 '20 16:08 makeacode

What seemed to be the fix? Was it in cert-manager itself? Next step before I will create a PR to this repo is to get the template variable on the issuer. In stead of within the controller-manager. Ps! Good to know to update to 1.16.1!

SimeonPoot avatar Aug 26 '20 17:08 SimeonPoot

I believe the only change i made was the upgrade to 1.16.1 because it definitely wasn't working before that. I just started messing with the ingress-shim and that doesn't seem to work... the following annotations

cert-manager.io/cluster-issuer: rootca
cert-manager.io/issuer-kind: "ClusterAdcsIssuer"
cert-manager.io/issuer-group: "adcs.certmanager.csf.nokia.com"

results in the following error:

E0826 17:21:14.389154 1 sync.go:54] cert-manager/controller/ingress-shim "msg"="failed to determine issuer to be used for ingress resource" "error"="both \"cert-manager.io/cluster-issuer\" and \"cert-manager.io/issuer-group\" may not be set, both \"cert-manager.io/cluster-issuer\" and \"cert-manager.io/issuer-kind\" may not be set" "resource_kind"="Ingress" "resource_name"="test-certificate" "resource_namespace"="docker-registry"

if I make the changes it suggests and remove the issuer-group and issuer-kind it generates the Certificate instance with the incorrect Group and Kind settings (as you might expect):

  Issuer Ref:
    Group:      cert-manager.io
    Kind:       ClusterIssuer
    Name:       rootca

removing the cluster-issuer and leaving the issuer-group and issuer-kind properties doesn't seem to do anything

makeacode avatar Aug 26 '20 18:08 makeacode

Ok....I figured out my problem...do not use the cluster-issuer even though it feels like you should. The following settings DO work:

cert-manager.io/issuer: rootca
cert-manager.io/issuer-kind: "ClusterAdcsIssuer"
cert-manager.io/issuer-group: "adcs.certmanager.csf.nokia.com"

makeacode avatar Aug 26 '20 18:08 makeacode

Nice one. I had to figure that out too. Maybe good idea to catch it in the Readme. Haven't got the custom ingress-certmanager annotations working with the ADCS-issuer.

SimeonPoot avatar Aug 26 '20 20:08 SimeonPoot