Florian Verdonck
Florian Verdonck
@tsnobip got it! Was wondering if that did any actual syncing, which would be a little strange for a PR.
> should I rename the job? Yes, please, that would be less confusing.
Hello, thank you for this PR! I can't review the code as I'm not suited enough for that. However, this looks interesting. If this gets accepted would you be ok...
Thanks for the review @64J0. Can we ship this as an alpha?
Try running `make test-analysis` to update those snapshots.
Yeah, I've seen this one. Try and replace `rescript clean` with `rescript legacy clean` in the package.json files of those test projects.
I need to press a button to approve running CI first. I believe this is because it is your first contribution.
You might also want to sync your PR with the latest main.
If the lock file is too much of a pain, I think I can live without them.
> Thinking about this more, how about they're kept for the main pipeline but we pass -p:RestoreLockedMode=false to the AOT-publish pipeline? Would work for me. > does the dev container...