Florian Verdonck
Florian Verdonck
Link to read: https://github.com/rescript-lang/rescript-vscode/blob/60f15534e4f735c5c176168adb85304ef1d7aa2f/analysis/README.md#tests
Aren't tooltips in FSAC their own thing? I always thought you gents rolled your own thing for tooltips.
@DZakh out of curiosity, does this change anything for the end-users?
@cometkim, just checking but do you want a review from me or @fhammerschmidt?
We share a first name, so that was why I was asking. Happy to review this.
This might be a nitpick but I got  after running `make test` locally.
Probably another nit pick: got this diff as well after running `make test`:  Other than that, I ran my typical commands in the compiler repo. Installed it locally inside...
> What's the version of Node.js you're using? `v22.13.1`
If we keep the name `lib_dev` for now, could we at least have a short markdown file in that folder to explain what its purpose is?
> > v22.13.1 > > Yep, you should downgrade then. see the `.nvmrc`. I'm using [mise](https://mise.jdx.dev/) for that Downgrading worked for me.