speeduino
speeduino copied to clipboard
WMI and VVT pin assignment confilct
First as you will see in the youtube video, whatever I change pin assignment for VVT then WMI will change automatically. In the opposite direction as well. I found that this also takes place if working in offline mode or connected I presume this is a mapping issue in TS or is this a speeduino configuration problem??
Please see: https://youtu.be/zorqhtIsj_s
Tunerstudio Version: TS MS Ultra v3.1.08 Speeduino Board: UA4C White Fang WTMtronix Speeduino Firmware: 202207.1
Is this in any way related to issue #582? Only correlation for me is I'm using pin 5 for WMI. Thanks again.
Currently you can only use one at time, both uses the same code internally, I made a PR(#845) to solve this, hope @noisymime analyse it for next release.
As mentioned, WMI and VVT cannot function together in the current firmware. I've just pushed up a warning for this in the ini, but the ultimate solution here is #845.
I'll keep this open as I expect to merge that PR early in the next dev cycle
As mentioned, WMI and VVT cannot function together in the current firmware. I've just pushed up a warning for this in the ini, but the ultimate solution here is #845.
I'll keep this open as I expect to merge that PR early in the next dev cycle
Did this change in the .ini file limit the user from configuring VVT and WMI simultaneously?
VitorBoss made a modification to test moving WMI to VVT2 function opening the potential for VVT1+WMI but I think this was prevented from testing by the sanity check found in the newest release for VVT+WMI conflict.
I opened the .ini but was not sure how to modify with breaking something along the way.
Did this change in the .ini file limit the user from configuring VVT and WMI simultaneously?
Yes it did, and this is intentional given the current timer arrangement.
VitorBoss made a modification to test moving WMI to VVT2 function opening the potential for VVT1+WMI but I think this was prevented from testing by the sanity check found in the newest release for VVT+WMI conflict.
When that PR is brought in I'll remove the newly added check. It wasn't going to make it in for the last release though, so better to have the warning at least
I'm currently testing for this modification. I should have a detailed report on my status this weekend. Currently it's not working for me.
I feel like the VVT2 settings dialog should be inhibited (allow VVT1) when WMI is enabled. This would allow for configuration of VVT1 and WMI in the expected places. Inverse of the current situation where we config VVT2 settings to handle WMI (as-is with boss's modification)
Furthermore, WMI settings like timing advance on WMI activation is inhibited by the current arrangement. Thanks for everyone's efforts.
On Thu, Jun 1, 2023, 9:12 PM Josh Stewart @.***> wrote:
Did this change in the .ini file limit the user from configuring VVT and WMI simultaneously?
Yes it did, and this is intentional given the current timer arrangement.
VitorBoss made a modification to test moving WMI to VVT2 function opening the potential for VVT1+WMI but I think this was prevented from testing by the sanity check found in the newest release for VVT+WMI conflict.
When that PR is brought in I'll remove the newly added check. It wasn't going to make it in for the last release though, so better to have the warning at least
— Reply to this email directly, view it on GitHub https://github.com/noisymime/speeduino/issues/1053#issuecomment-1572985026, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACQVJCEBA3FCLSFF4H7GTCDXJE4YLANCNFSM6AAAAAAYPT3DJQ . You are receiving this because you authored the thread.Message ID: @.***>
I just wanted to update this issue/topic in hope that VitorBoss's patch makes it to main stream for enabling VVT1 and WMI simultaneously. This seems to be working just perfect for me with the exception of a table values isn't persistent and must send tunerstudio settings to ecu each connect. Otherwise, works.
Just wanted to bump this topic/issue. I have been running the patch for this that VitorBoss worked up. It works flawless except the WMI table data is corrupted on reboot of the ecu or connect of tunerstudio I'm not sure. For whatever reason the values just become random. Having tested this for months on reliability I can confirm with this patch Single VVT with WMI enabled works just great otherwise.
Closing as this is now resolved with #845