NoiseTorch icon indicating copy to clipboard operation
NoiseTorch copied to clipboard

refactor: Remove vendor folder

Open bentenjamin opened this issue 2 years ago • 6 comments

Removed vendor folder: Issue 290

Tested locally on fresh install make dev builds and runs successfully

Created local private key with go run scripts/signer.go -g make release builds, signs and runs successfully

bentenjamin avatar May 26 '22 18:05 bentenjamin

Removing vendor folder from Repository sounds very reasonable to. Should make all code reviews in future easier. I am not a go guy, thus I cannot tell if there is something special to take into account when removing vendor folders, but in general it is best practice I guess ;)

mackshot avatar May 27 '22 09:05 mackshot

this PR as is would work. no further steps required. Though the discussion in #284 is not finished yet. There you also can find opinions and reasons for not removing the vendor folder.

ZyanKLee avatar May 27 '22 09:05 ZyanKLee

Unless I missed it in the file list, was the vendor folder added to the .gitignore? If not, I believe that's something that we'll want to do to avoid committing the vendor folder back to the repo.

TheDukeofErl avatar May 27 '22 12:05 TheDukeofErl

Why remove the vendor directory? It makes it kinda easier when doing code reviews for getting new dependencies. You can have a CI system that validates the vendor directory hasn't been manually modified.

aaomidi avatar May 29 '22 03:05 aaomidi

Why remove the vendor directory? It makes it kinda easier when doing code reviews for getting new dependencies. You can have a CI system that validates the vendor directory hasn't been manually modified.

Hello, we discussed that matter in #284 - feel free to add your opinion there. I'll wait a few days for it, before going forward with it. So you get a last chance to convince me otherwise 😉

ZyanKLee avatar Jun 10 '22 11:06 ZyanKLee

Thanks for the link, I'll do my best to participate in the discussion soon (out of the country with limited access for a bit).

Cheers!

aaomidi avatar Jun 10 '22 11:06 aaomidi