noirello

Results 35 comments of noirello

It's a little bit complicated to create `manylinux` wheels for bonsai. It has quite significant library dependencies. One of them is `libssl`, which included in a wheel could cause problems...

Hi, thanks for reporting it. I added both of your recommendations: * set the `maxsplit` for splitting text lines, so colons in values will be accepted, unless it's the first...

TBH, I'm kind of lost about this issue. I'm not sure how Apache Arrow solved it to avoid collision with other protobuf using modules. I'll try to look into it...

Are you sure about this memory leak? It isn't exactly straight forward, but I think the LDAP structure will be freed eventually during the deallocation of the LDAPConnection [here](https://github.com/noirello/bonsai/blob/master/src/_bonsai/ldapconnection.c#L12) with...

Yes, the close method does more, than it probably should. Before the unbind, it sends out abandon requests for the unfinished operations. These are kind of a fire-and-forget requests, that's...

This is the idea, that I was talking about: https://github.com/noirello/bonsai/compare/dev...optional-abandon This way the close method wouldn't do extra abandon operations by default, and it has fewer chances to raise error.

It seems a too drastic measure for me at that level, that could easily lead silent fails (simple messages can be overlooked). I've [changed](https://github.com/noirello/bonsai/commit/f482c722bc4e066c0f222352991921b3e59372aa) the `ConnectionPool.close()` almost as you suggested...

I've checked that you can call close on a disconnected/stopped LDAP server without errors. Also looked through the OpenLDAP source code, and it seems to me that `ldap_unbind_ext` always returns...

> One more thing here - according to https://linux.die.net/man/3/ldap_unbind_ext (Unbinding section): The ldap_unbind_s() call is just another name for ldap_unbind(); both of these calls are synchronous in nature. The `ldap_unbind_ext`...