noirup icon indicating copy to clipboard operation
noirup copied to clipboard

chore: add cleanup for bb installation

Open kobyhallx opened this issue 2 years ago • 2 comments
trafficstars

Adds cleanup for acvm-backend-barretenberg when performing new installation.

kobyhallx avatar Oct 13 '23 18:10 kobyhallx

I don't think this should be merged in its current form for a couple of reasons:

  • This PR currently nukes the entire backend directory including the CRS so users will have to redownload it from scratch. This unnecessarily slows down the UX as the CRS can be shared between bb versions.
  • The suggested changes to https://github.com/noir-lang/noir/pull/3150 remove the need for this PR when updating to future versions of nargo.
  • It's generally "abstraction leaky", there's no reason for noirup to be aware of backends.

TomAFrench avatar Oct 16 '23 09:10 TomAFrench

I think its generally a good practive to clean particular backend before installing new one. Your current artifacts may be broken or out dated and cleanup would help with this.

kobyhallx avatar Oct 16 '23 10:10 kobyhallx