feat: separating out array and slice types in the AST

[michaeljklein]

Description

Replacement for https://github.com/noir-lang/noir/pull/4232. Holding off on closing it to possibly port fixes from it, but wanted to start fresh because this approach is quite different.

Problem*

Resolves https://github.com/noir-lang/noir/issues/4220

Summary*

Additional Context

Documentation*

Check one:

• [ ] No documentation needed.
• [ ] Documentation included in this PR.
• [ ] [Exceptional Case] Documentation to be submitted in a separate PR.

PR Checklist*

• [ ] I have tested the changes locally.
• [ ] I have formatted the changes with Prettier and/or cargo fmt on default settings.

[jfecher]

Actually, just looked at the error message in that example more closely. It looks like somewhere the argument order for Type::Array was reversed

[vezenovm]

@jfecher What do we think about using as_slice() for slice literals rather than &[]. Do we think that syntax will be confusing for users with us not supporting immutable references?

[github-actions[bot]]

🚀 Deployed on https://65f9ebd020e5b411edfa757a--noir-docs.netlify.app

[github-actions[bot]]

FYI @noir-lang/developerrelations on Noir doc changes.