noir icon indicating copy to clipboard operation
noir copied to clipboard

Epic: Deprecate nested slices

Open vezenovm opened this issue 2 years ago • 3 comments

Handling for nested slices has already required a good amount of prep work but still has a few more tasks before it can be labelled fully complete.

The current status of nested slices is that a new pass has been introduced that fills nested slices with dummy data so that the internal types match up in size. The fill internal slices pass is necessary to get dynamic nested slices working in ACIR. This is the initial pass (https://github.com/noir-lang/noir/pull/3258). However, this pass currently only works with one block and needs to be expanded to handle filling of dummy data in flattening. I have made this task list to better track what issues are leftover to complete.

#3187 is the initial work that prompted the fill internal slices pass.

### Tasks
- [ ] https://github.com/noir-lang/noir/pull/3258
- [ ] https://github.com/noir-lang/noir/pull/3187
- [ ] https://github.com/noir-lang/noir/issues/3188
- [ ] https://github.com/noir-lang/noir/issues/3364
- [ ] https://github.com/noir-lang/noir/issues/2462
- [ ] https://github.com/noir-lang/noir/issues/2909
- [ ] https://github.com/noir-lang/noir/issues/3476
- [ ] https://github.com/noir-lang/noir/issues/3637

Ban nested slices tracker:

### Tasks
- [ ] https://github.com/noir-lang/noir/issues/4017
- [ ] https://github.com/noir-lang/noir/issues/4019
- [ ] https://github.com/noir-lang/noir/issues/4020

As per this comment this is a following task list of any remaining slice issues that need to be resolved to state that slices are fully stable:

### Tasks
- [ ] https://github.com/noir-lang/noir/issues/4202
- [ ] https://github.com/noir-lang/noir/issues/3687
- [ ] https://github.com/noir-lang/noir/issues/2540
- [ ] https://github.com/noir-lang/noir/issues/4220
- [ ] https://github.com/noir-lang/noir/issues/2535

There is also issue https://github.com/noir-lang/noir/issues/1344 for enabling printing of slices. This would be a more feature update and we might be able to tie into a general refactor of formatting strings in Noir.

vezenovm avatar Oct 30 '23 19:10 vezenovm

After an internal meeting and the complexity introduced in https://github.com/noir-lang/noir/pull/3979 we have decied to temporarily shelve nested slices. In the main issue a new tracklist has been created to mark their removal.

vezenovm avatar Jan 11 '24 18:01 vezenovm

Once we merge the ban nested slices PR, can you check the bugs/issues/tasks that are related to slices to see if they are still relevant?

kevaundray avatar Jan 15 '24 19:01 kevaundray

I will leave https://github.com/noir-lang/noir/issues/528 to be closed once this issue is closed.

vezenovm avatar Feb 05 '24 20:02 vezenovm

Closing this issue now that all tasks have been completed. Any new slice bugs can be separate from this issue.

vezenovm avatar Mar 20 '24 17:03 vezenovm