nvim-oxi icon indicating copy to clipboard operation
nvim-oxi copied to clipboard

Published 20 hours ago • verified publisher icon noib3

Allow getting the buffer handle and make `Buffer` copy

Open oberblastmeister opened this issue 2 years ago • 2 comments

Getting the internal handle is useful when nxim_oxi hasn't made bindings to something yet. I also don't see why Buffer shouldn't be Copy, as it's just an integer. I also don't see how the internals of Buffer could be changed to something !Copy in the future. I think the other types like Window should be made Copy too.

oberblastmeister avatar Oct 22 '22 12:10 oberblastmeister

@noib3 Is this okay?

oberblastmeister avatar Jan 28 '23 00:01 oberblastmeister

@noib3 Is this okay?

@oberblastmeister sorry for keeping it open so long, I'll make sure to review this this weekend.

noib3 avatar Jan 28 '23 00:01 noib3

Closed by #176, which added a fn handle(&self) -> i32 method on Buffer, Window and TabPage.

Neither of those is Copy atm, but I think if we were to make them we should also probably change all the methods from taking &self and &mut self to taking self, which is a breaking change.

noib3 avatar Jun 14 '24 03:06 noib3