noflo-ui icon indicating copy to clipboard operation
noflo-ui copied to clipboard

New network is always created, causes duplicates in runtime

Open djdeath opened this issue 11 years ago • 6 comments

When connecting to a runtime and starting a graph, a network is created and started on the runtime. Currently, there is no way to shutdown a running network. As a result, if you disconnect the UI from the runtime and reconnect it and click the "start" button again, you now have 2 networks running at the same time. It would be really good to either have a way to "reconnect" to a previously started network and be able to stop it, or have a way to list all the running networks and be help to shutdown some of them.

Otherwise, you pretty much have to restart your runtime everytime you want to restart a new network.

djdeath avatar Apr 04 '14 16:04 djdeath

This is something we took into account with the runtime protocol. However, it is not yet utilised in either the runtimes or the UI

bergie avatar Apr 07 '14 08:04 bergie

It seems the protocol still misses the method to list running/stopped networks, or am I blind? :)

djdeath avatar Apr 07 '14 09:04 djdeath

The assumption is that runtime runs a single network at a time, in which case the graph key we have there would be enough. In case of multiple networks we could probably allow the graph key to be an array of ids

bergie avatar Apr 07 '14 09:04 bergie

Ok, that's clear now :) There is still a problem at the moment with the disconnection of the UI from the runtime. When the UI reconnects, it has no idea that a network was left running and therefore if you start the graph from the UI again, you now have 2 networks running concurrently.

What do you think should be done to solve that problem?

djdeath avatar Apr 07 '14 09:04 djdeath

@djdeath we can fix this by making the UI start a connection by getting runtime info and then respecting it

bergie avatar Apr 07 '14 09:04 bergie

@bergie is this fixed by recent changes to runtime handling?

jonnor avatar Aug 27 '15 18:08 jonnor