featherlight icon indicating copy to clipboard operation
featherlight copied to clipboard

Providing scss files for better modularity

Open andreasisaak opened this issue 9 years ago • 4 comments

Would it be possible that you providing scss files with the package? If desired, i write the pull request :)

andreasisaak avatar Jan 21 '16 12:01 andreasisaak

That could be nice, except it is not trivial to do.

We currently use the src/ files directly when developing & testing. There would have to be a "compiling process". It wouldn't be worth the annoyance just for scss though. But If we are to do this, we could as well move to ES6. I'd like to do that one day (like I did with Parsley). It would be easy to add scss processing to the gulp file.

In short: producing the scss file is easy, but it would have to be after a move to ES6. Adapting the project to ES6 is a bit more involved...

marcandre avatar Jan 21 '16 15:01 marcandre

I think you're right but there are just 3 CSS changes last year. Theoretically, we could first offer SCSS and CSS simultaneously

andreasisaak avatar Jan 22 '16 09:01 andreasisaak

I have a question. Why would converting the CSS to SCSS require converting the JS to ES6 syntax first? It would be super simple to add the SCSS file and then update the gulpfile to add that compiling step in...

EDIT: Just realized this uses Grunt instead of Gulp. Anyways, wouldn't be difficult to add this. Also you should convert over to Gulp ;-)

Jakobud avatar Jun 29 '16 19:06 Jakobud

You're right, we could do those in any order. I'd accept a PR for grunt to gulp and/or a PR from css to scss

marcandre avatar Jun 29 '16 22:06 marcandre