node-vault icon indicating copy to clipboard operation
node-vault copied to clipboard

Update dependencies

Open pratikpc opened this issue 2 years ago • 1 comments

Update dependencies

  1. Istanbul has changed to NYC and the corresponding changes
  2. Update ESLint which led to configuration changes and requirements to fix the code in most files in the repo
  3. Switch to Postman Request which is the same Request we all use except with some patches and currently being used internally by Postman.

Need help

  const requestOld = (config['request-promise'] || originalRp).defaults(rpDefaults);
  const rp = function rp(options) {
    // Discuss how to handle this
    if (config['request-promise'] != null) {
      return requestOld(options);
    }
    return new Promise((resolve, reject) => {
      requestOld(options, (err, response, _body) => {
        if (err != null) reject(err);
        else resolve(response);
      });
    });
  };

How to handle when old request is provided as request promise?

Should we have 3 parameters for

  1. Request
  2. Request Promise
  3. Request

Should I split the PR into both cleanup/updates and Postman Request switch?

pratikpc avatar Jan 26 '22 00:01 pratikpc

Support for Node.JS 6 is a lot more difficult than I imagined it would be.

Making this PR a draft and removing the Postman Request section from here.

Creating a new PR

pratikpc avatar Jan 26 '22 09:01 pratikpc

@pratikpc what's going on with this PR? need any help?

aviadhahami avatar Nov 10 '22 17:11 aviadhahami

👋 Heya! closing this as most of the added changes already present in the repo. Updating request will occur soon :)

aviadhahami avatar May 11 '23 15:05 aviadhahami