node-vault
node-vault copied to clipboard
Replace Request with Axios
This is a rebasing/fixup of #151.
One feature added after the original PR was submitted was the rpOptions
configuration option which allows any option to be passed through to request-promise
(see #125). This is arguably a bit of a leaky abstraction and would be difficult to implement with any degree of completeness (it would require a full mapping of request options to axios options which seems beyond the scope of this module). It seems like the original intent was just to allow an agent to be passed through to the underlying request library (which could be easily accomplished). We could also consider allowing various Axios-specific options to be passed through but regardless, for now, I've just skipped the existing test that exercised the rpOptions
pending specific direction for how compatible we need to keep the API given the challenges I've mentioned.
Codecov Report
Merging #190 (fc070bc) into master (18597dd) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #190 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 146 159 +13
Branches 37 42 +5
=========================================
+ Hits 146 159 +13
Impacted Files | Coverage Δ | |
---|---|---|
src/index.js | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 18597dd...fc070bc. Read the comment docs.
@kr1sp1n Could you please let me know how to proceed, specifically with the rpOptions
issue with removing request-promise
support?
@brianphillips see my comment here: https://github.com/kr1sp1n/node-vault/issues/150#issuecomment-1007339290
Closing in favor of #150