node-vault icon indicating copy to clipboard operation
node-vault copied to clipboard

Fix #175, handle trailing slash on endpoint

Open wes-novack opened this issue 5 years ago • 5 comments

wes-novack avatar Jan 05 '21 22:01 wes-novack

Codecov Report

Merging #176 (e97f19b) into master (7009726) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       147    +1     
  Branches        37        37           
=========================================
+ Hits           146       147    +1     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7009726...e97f19b. Read the comment docs.

codecov[bot] avatar Jan 05 '21 23:01 codecov[bot]

Hello @kr1sp1n ! We're not sure why 1 of the checks didn't complete on this PR. Can you provide any context on this?

wes-novack avatar Jan 08 '21 21:01 wes-novack

@wes-novack do you mind updating the base branch? (can't do it via the UI here)

aviadhahami avatar Nov 10 '22 17:11 aviadhahami

I no longer have access to the repo. @GoFightNguyen can you help here?

wes-novack avatar Nov 10 '22 19:11 wes-novack

Codecov Report

Merging #176 (e97f19b) into master (18597dd) will not change coverage. The diff coverage is 100.00%.

:exclamation: Current head e97f19b differs from pull request most recent head 791e322. Consider uploading reports for the commit 791e322 to get more accurate results

@@            Coverage Diff            @@
##            master      #176   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       147    +1     
  Branches        37        37           
=========================================
+ Hits           146       147    +1     
Impacted Files Coverage Δ
src/index.js 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov-commenter avatar Nov 13 '22 17:11 codecov-commenter