Replacing Request with another library

[pratikpc]

As of https://github.com/request/request/issues/3142, the Request Library and Request-Promise library on which Node-Vault depend, have both been deprecated

As such, I believe that, we must replace Request with another library The async libraries which could replace it are

1. Node-Fetch
2. Axios
3. Any Other ??

[bjankord]

It would be nice to find an alternative for request. There is a thread on https://github.com/request/request/issues/3143 about alternatives.

[pratikpc]

@bjankord I tried my hand at replacing Request with axios in this pull request

Let's see if it's accepted

[fungiboletus]

A good alternative to request is got IMHO.

[muturgan]

@bjankord I tried my hand at replacing Request with axios in this pull request

Let's see if it's accepted

axios is amasing

[aviadhahami]

I'd like to budge in and offer needle

[delfuego]

For me, the prime driver for replacing request is that it brings along 20 additional dependencies that are almost certainly not needed by upstream projects. Given that there was a pull request to move to axios submitted above, is there any way to nudge this along? It would be really great to resolve this one.

[jjnkr]

This issue is affecting me as well, because having request-promise and request-promise-native in the dependency tree causes problems when testing with Jest: https://github.com/request/request-promise/issues/247

Is there any way to help the axios PR along?

[adam2k]

It seems like this PR was opened over a year ago. Is this project no longer maintained and are there alternatives?

[aviadhahami]

@adam2k seems so [unmaintained]

[tgrassl]

@kr1sp1n Any updates on this?

[adam2k]

@aviadhahami do you know of any other good alternatives and is it worth forking this repo at this point?

[aviadhahami]

@adam2k - per "is it worth" --> there are 52K downloads per week of this pkg (according to npm)

@pratikpc , regarding https://github.com/kr1sp1n/node-vault/pull/151, any progress? the last comment was asking to fix the conflicts. Can you attend this? (if not - I believe others [including myself] are able to help :) )

[adam2k]

@aviadhahami I'm unfamiliar with the npm process of forking a project like this. I suppose we could fork and make a new project that is open sourced. I'll talk with my company about working on a project like this to see if I can get support from them as well.

[aviadhahami]

@adam2k not sure myself as well, I think we can maintain this if you'd like :) @kr1sp1n - is this 100% stale on your end? if yes - would u like to move ownership to @adam2k & myself?

[aviadhahami]

Update - emailed npm themselves for a dispute on package name due to owner's inactivity and the security risk imposed by this

[adam2k]

@aviadhahami I'm discussing with my company to see if they want to fork and take on ownership of this repo. We should have a response by the end of this week.

[kr1sp1n]

@aviadhahami Hi, I would like to move the ownership to you. I do not maintain this lib any longer but I would love to hand it over to responsible people. Let me know where to move it exactly.

[aviadhahami]

Hi @kr1sp1n, thx for the reply :)

Steps needed for transfer: 1/ Change npm ownership [howto] [my npm profile] 2/ Change GH ownership [howto] [my gh profile]

IMO that's it. lmk if u need any help or anything :)

[adam2k]

Thanks @kr1sp1n and @aviadhahami! 👍🏻

[adam2k]

@aviadhahami and @kr1sp1n let me know if you all need anything from me in the immediate term. Otherwise I'll open up PRs in @aviadhahami's repo when it's ready to go.

[pratikpc]

Hey guys I think the safest option is Postman Request.

Asio would be a bit of a headache to port as I found out myself and would definitely break existing code for users so we can move to Postman Request for the time being.

Postman Request is the request we love and admire (I don't) with the bugs fixed and slightly less warnings (It's named so because it is maintained by @postmanlabs) I was also able to update a lot of the codebase and dependencies and fix code with the newer changes as recommended by our Airbnb overlords with a few ignored

@aviadhahami done!

[adam2k]

@aviadhahami and @kr1sp1n do you all have an idea when this repo could be transferred?

[aviadhahami]

@adam2k I'm waiting patiently 🤷‍♂️

[kr1sp1n]

@adam2k @aviadhahami I added @aviadhahami to the npm maintainers, created a github organization called "nodevault" (node-vault was already taken) and invited @aviadhahami as a member. That should do the trick, right?

[aviadhahami]

@kr1sp1n almost :D I still lack permissions and get this:

So, what's left to do is: 1/ give repo permissions 2/ give npm permissions (for publishing)

[aviadhahami]

@kr1sp1n pinging again (so we can stop ping you <3 ) lmk if u wanna zoom on this so we can tie all ends and get it over with :)

[xenoterracide]

has someone forked? as far as github just fork (could do as not even a "click fork", just clone and push to a new repo), npm rights are more important, as to update all of the info.

[ghost]

@kr1sp1n was the missing ownership ever resolved?

[aviadhahami]

@kr1sp1n added me to the org so I can collab, but I still lack permissions to the repo 😕

Siri, play "we're half way there"

[aviadhahami]

@kr1sp1n, please, if you can clear up an hour (±) we can do a handover and I can help maintain 🙏