node-vault icon indicating copy to clipboard operation
node-vault copied to clipboard

Move Request types to dependencies & fix functionConf type

Open Kamahl19 opened this issue 4 years ago • 4 comments

@types/request needs to be a dependency instead of devDependency. If we build a library with node-vault as dependency, @types/request are missing

It also fixes functionConf type

Kamahl19 avatar Mar 02 '20 17:03 Kamahl19

@kr1sp1n This fixes the issue introduced in https://github.com/kr1sp1n/node-vault/pull/142

Kamahl19 avatar Mar 02 '20 17:03 Kamahl19

Codecov Report

Merging #146 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #146   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          139       139           
  Branches        34        34           
=========================================
  Hits           139       139           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17f06aa...9869abf. Read the comment docs.

codecov[bot] avatar Mar 02 '20 17:03 codecov[bot]

@kr1sp1n Could you please take a look on this one? It fixes 2 bugs with types introduced lately.

Kamahl19 avatar Mar 30 '20 17:03 Kamahl19

@Kamahl19 do you mind removing the package.json change?

aviadhahami avatar Nov 10 '22 17:11 aviadhahami