node-vault
node-vault copied to clipboard
Move Request types to dependencies & fix functionConf type
@types/request needs to be a dependency instead of devDependency. If we build a library with node-vault as dependency, @types/request are missing
It also fixes functionConf type
@kr1sp1n This fixes the issue introduced in https://github.com/kr1sp1n/node-vault/pull/142
Codecov Report
Merging #146 into master will not change coverage by
%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #146 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 2 2
Lines 139 139
Branches 34 34
=========================================
Hits 139 139
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 17f06aa...9869abf. Read the comment docs.
@kr1sp1n Could you please take a look on this one? It fixes 2 bugs with types introduced lately.
@Kamahl19 do you mind removing the package.json
change?