admin GH Variables into a .config file

GH Variables into a .config file

Open fforres opened this issue 9 years ago • 5 comments

trafficstars

What if we add a fallback for the Github variables gh-token, gh-client-id, gh-client-secret into a .config file that you could fill?

i.e. @ groupon we have those env. variables already set into our computers, but for Groupon's Enterprise Github.

Jan 20 '16 16:01 fforres

PR welcome :smile: :+1:

Jan 20 '16 16:01 martinheidegger

Will do :)

Jan 20 '16 16:01 fforres

Adding a PR: https://github.com/nodeschool/admin/pull/30

Jan 23 '16 22:01 fforres

I think we can close this one because we wont need github variables. What do you think @martinheidegger

Feb 18 '16 21:02 dinodsaurus

For the moment this PR has become obsolete but we might need it in future versions if we add advanced features to the tool

Mar 08 '16 22:03 martinheidegger