react-dom-inject icon indicating copy to clipboard operation
react-dom-inject copied to clipboard

`children` does not work

Open atmin opened this issue 9 years ago • 1 comments

props.children does not work, so currently the README example is a bit misleading by using {children}.

Great lib, nevertheless. data-* properties already provide a seamless way for ServerSideTemplatingEngine--React interaction.

atmin avatar Jul 12 '16 12:07 atmin

Sorry for the 3 month late response.. I have been missing some notifications.

The legacy application I was using this in outgrew it's need for this hence no updates. I can see that I did indeed write the code to snag the innerHTML off an element and inject it however it is commented out. I have no recollection why I did this other than I had no need for it in my app and did not pursue. I'll try and get the readme updated to reflect or possibly add the support in near future. Thanks for reporting!

cchamberlain avatar Oct 19 '16 05:10 cchamberlain