undici icon indicating copy to clipboard operation
undici copied to clipboard

feat(dispatcher/env-http-proxy-agent): strip leading dot and asterisk

Open SuperOleg39 opened this issue 1 month ago • 3 comments

This relates to...

https://github.com/nodejs/undici/discussions/4618

Rationale

no_proxy matching logic changes related to current behaviour in curl, deno and this specification - https://about.gitlab.com/blog/we-need-to-talk-no-proxy/

Changes

  • strip leading dot, so no_proxy=.example.com is equivalent to no_proxy=example.com
  • strip leading asterisk with dot, so no_proxy=*.example.com is equivalent to no_proxy=example.com
  • drop support for substring suffix (this syntax is not specified anywhere), so no_proxy=*example is equivalent to no_proxy="" or the absence of a no_proxy variable

Breaking Changes and Deprecations

Сhanges in the current Merge Request can be considered as breaking.

Status

  • [x] I have read and agreed to the Developer's Certificate of Origin
  • [x] Tested
  • [ ] Benchmarked (optional)
  • [x] Documented
  • [x] Review ready
  • [ ] In review
  • [ ] Merge ready

SuperOleg39 avatar Nov 24 '25 16:11 SuperOleg39

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 92.85%. Comparing base (148e0ef) to head (081d2c9). :warning: Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #4676       +/-   ##
=========================================
+ Coverage      0   92.85%   +92.85%     
=========================================
  Files         0      107      +107     
  Lines         0    33498    +33498     
=========================================
+ Hits          0    31103    +31103     
- Misses        0     2395     +2395     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov-commenter avatar Nov 24 '25 16:11 codecov-commenter

@joyeecheung can you review?

mcollina avatar Nov 28 '25 21:11 mcollina

@joyeecheung can you review?

Just reminder 🙏

SuperOleg39 avatar Dec 10 '25 16:12 SuperOleg39