undici icon indicating copy to clipboard operation
undici copied to clipboard

Move logic to interceptors

Open ronag opened this issue 3 months ago • 4 comments

Once https://github.com/nodejs/undici/pull/2826 lands we can start moving some logic into interceptors in order to ensure we get similar logic for all api implementations:

  • [ ] throwOnError as interceptor
  • [ ] dump as interceptor
  • [ ] signal handling as interceptor

ronag avatar Mar 10 '24 18:03 ronag

Shall we mark them as good-first-issue? I believe that at least two of them (signaling and throwOnError) can be done easily

metcoder95 avatar Mar 10 '24 18:03 metcoder95

I don't think this needs to be semver major.

ronag avatar Mar 10 '24 18:03 ronag

Hi @ronag

I'm interested in this topic, can I pick this?

stu01509 avatar Mar 30 '24 13:03 stu01509

go for it!

mcollina avatar Mar 31 '24 13:03 mcollina