undici
undici copied to clipboard
remove FileReader
When we eventually drop support for node 18, we can finally get rid of our File implementation, which means we won't have to run any FileAPI WPTs anymore!
Unfortunately I don't think we can drop Node v18 anytime soon because it’ll be lts for another year.
Of course not 😅. I was just talking about way in the future. We still have our own File.
Rebase to next branch?
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
:exclamation: No coverage uploaded for pull request base (
next@8a940ec
). Click here to learn what that means.
Additional details and impacted files
@@ Coverage Diff @@
## next #2728 +/- ##
=======================================
Coverage ? 88.44%
=======================================
Files ? 81
Lines ? 7384
Branches ? 0
=======================================
Hits ? 6531
Misses ? 853
Partials ? 0
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
can we land this? 👀
I made a PR to remove FileReader from fetch tests. This is safe to land in the meantime. https://github.com/web-platform-tests/wpt/pull/44893/
I guess this can land in next? What is blocking this?
Now that we've removed our File impl. we can stop running the fileapi WPTs altogether.