undici icon indicating copy to clipboard operation
undici copied to clipboard

remove FileReader

Open KhafraDev opened this issue 1 year ago • 9 comments

KhafraDev avatar Feb 09 '24 17:02 KhafraDev

When we eventually drop support for node 18, we can finally get rid of our File implementation, which means we won't have to run any FileAPI WPTs anymore!

KhafraDev avatar Feb 09 '24 17:02 KhafraDev

Unfortunately I don't think we can drop Node v18 anytime soon because it’ll be lts for another year.

mcollina avatar Feb 10 '24 14:02 mcollina

Of course not 😅. I was just talking about way in the future. We still have our own File.

KhafraDev avatar Feb 10 '24 14:02 KhafraDev

Rebase to next branch?

ronag avatar Feb 25 '24 09:02 ronag

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

:exclamation: No coverage uploaded for pull request base (next@8a940ec). Click here to learn what that means.

Additional details and impacted files
@@           Coverage Diff           @@
##             next    #2728   +/-   ##
=======================================
  Coverage        ?   88.44%           
=======================================
  Files           ?       81           
  Lines           ?     7384           
  Branches        ?        0           
=======================================
  Hits            ?     6531           
  Misses          ?      853           
  Partials        ?        0           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Feb 25 '24 15:02 codecov-commenter

can we land this? 👀

KhafraDev avatar Mar 01 '24 22:03 KhafraDev

I made a PR to remove FileReader from fetch tests. This is safe to land in the meantime. https://github.com/web-platform-tests/wpt/pull/44893/

KhafraDev avatar Mar 01 '24 22:03 KhafraDev

I guess this can land in next? What is blocking this?

Uzlopak avatar Apr 08 '24 01:04 Uzlopak

Now that we've removed our File impl. we can stop running the fileapi WPTs altogether.

KhafraDev avatar Apr 22 '24 15:04 KhafraDev