undici icon indicating copy to clipboard operation
undici copied to clipboard

Protocol from proxy url is ignored when building proxy Agent

Open cheenamalhotra opened this issue 1 year ago • 1 comments

Bug Description

Imagine proxy URL in format: http://123.123.1.1:8080

Code here: https://github.com/nodejs/undici/blob/3a77cbb471b76175898d8b094beb9b40ceadd671/lib/proxy-agent.js#L33

Doesn't respect 'http' protocol if specified in proxy Url.

Environment

Node 18

cheenamalhotra avatar Oct 31 '23 05:10 cheenamalhotra

It somehow relates to #2278, would be better if we fully support the URL object instead

metcoder95 avatar Oct 31 '23 11:10 metcoder95

Closed by #2810

metcoder95 avatar Apr 02 '24 13:04 metcoder95