undici icon indicating copy to clipboard operation
undici copied to clipboard

fix: abort with signal reason

Open ronag opened this issue 1 year ago • 2 comments

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

  • [ ] I have read and agreed to the Developer's Certificate of Origin
  • [ ] Tested
  • [ ] Benchmarked (optional)
  • [ ] Documented
  • [ ] Review ready
  • [ ] In review
  • [ ] Merge ready

ronag avatar Sep 25 '23 18:09 ronag

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (f258549) 78.60%. Report is 54 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2289      +/-   ##
==========================================
- Coverage   85.54%   78.60%   -6.95%     
==========================================
  Files          76       76              
  Lines        6858     6872      +14     
==========================================
- Hits         5867     5402     -465     
- Misses        991     1470     +479     
Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
lib/api/abort-signal.js 100.00% <100.00%> (ø)
lib/api/readable.js 90.76% <100.00%> (-0.77%) :arrow_down:
lib/core/connect.js 80.00% <100.00%> (-1.25%) :arrow_down:
lib/core/request.js 92.38% <100.00%> (+5.29%) :arrow_up:
lib/fetch/body.js 97.20% <100.00%> (-0.48%) :arrow_down:
lib/fetch/global.js 100.00% <ø> (ø)
lib/fetch/index.js 83.86% <100.00%> (-1.34%) :arrow_down:
lib/pool.js 100.00% <100.00%> (ø)
lib/client.js 93.18% <93.33%> (+0.06%) :arrow_up:
... and 3 more

... and 11 files with indirect coverage changes

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov-commenter avatar Sep 25 '23 18:09 codecov-commenter

Loads of failing tests :(

mcollina avatar Sep 26 '23 13:09 mcollina