undici icon indicating copy to clipboard operation
undici copied to clipboard

test: issue #2026

Open AriPerkkio opened this issue 2 years ago • 1 comments

  • Failing test case for #2026

image

Example of failure on CI: https://github.com/AriPerkkio/undici/actions/runs/4551514748/jobs/8025677893#step:14:12832

Somehow tap is able to kill the process even though workers cannot terminate. I'm not sure how it does that as the reproduction case of #2026 cannot exit main thread even when it calls process.exit().

Replace fetch with request and test case will pass.

const requests = Array(count)
-  .fill(urls.map((url) => fetch(url).then((r) => r.json())))
+  .fill(urls.map((url) => request(url).then((r) => r.body.json())))

AriPerkkio avatar Mar 29 '23 08:03 AriPerkkio

Codecov Report

Patch coverage has no change and project coverage change: +0.30 :tada:

Comparison is base (a9ef509) 89.50% compared to head (8463224) 89.81%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
+ Coverage   89.50%   89.81%   +0.30%     
==========================================
  Files          70       71       +1     
  Lines        6173     6174       +1     
==========================================
+ Hits         5525     5545      +20     
+ Misses        648      629      -19     

see 3 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Mar 29 '23 08:03 codecov-commenter