undici icon indicating copy to clipboard operation
undici copied to clipboard

feat: expose socket info on request

Open fengmk2 opened this issue 3 years ago • 2 comments

fengmk2 avatar Sep 24 '22 09:09 fengmk2

Codecov Report

Base: 94.89% // Head: 94.83% // Decreases project coverage by -0.06% :warning:

Coverage data is based on head (9de66f6) compared to base (9c3f34c). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1665      +/-   ##
==========================================
- Coverage   94.89%   94.83%   -0.07%     
==========================================
  Files          53       53              
  Lines        4803     4803              
==========================================
- Hits         4558     4555       -3     
- Misses        245      248       +3     
Impacted Files Coverage Δ
lib/api/api-request.js 100.00% <100.00%> (ø)
lib/client.js 97.63% <100.00%> (ø)
lib/core/request.js 100.00% <100.00%> (ø)
lib/fetch/constants.js 82.35% <0.00%> (-17.65%) :arrow_down:

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

codecov-commenter avatar Sep 24 '22 09:09 codecov-commenter

@ronag request error will contains socket info https://github.com/nodejs/undici/blob/main/lib/client.js#L967 , should keep the same behaviour.

fengmk2 avatar Sep 24 '22 10:09 fengmk2