repl icon indicating copy to clipboard operation
repl copied to clipboard

feat: Initial test case for repl errors

Open antsmartian opened this issue 6 years ago • 7 comments

Hey @devsnek

I worked on the item : https://github.com/nodejs/repl/issues/6

This should be the beginning for adding test cases for repl 👍

Have a look and let me know we can follow the same pattern for other test cases too. Once this is good, may be we can then add scripts to run our tests on our npm build process.

Thanks for your time on this.

antsmartian avatar Jul 28 '18 15:07 antsmartian

@devsnek Thanks for your help. I have refactored the assertion accordingly. Let me know if anything needs to be done further.

antsmartian avatar Jul 30 '18 15:07 antsmartian

ping @devsnek

antsmartian avatar Aug 01 '18 14:08 antsmartian

ping @devsnek

antsmartian avatar Aug 12 '18 03:08 antsmartian

i'd like to see if we can set up CI of some sort for the linter before we merge more PRs

devsnek avatar Aug 21 '18 03:08 devsnek

@devsnek Perfect! Sounds good to me.

antsmartian avatar Aug 21 '18 03:08 antsmartian

@devsnek Any update on this?

antsmartian avatar Oct 28 '18 09:10 antsmartian

I know it's a long time, any update here? cc @devsnek

antsmartian avatar Feb 11 '20 10:02 antsmartian