readable-stream icon indicating copy to clipboard operation
readable-stream copied to clipboard

Typo in importing `process` in multiple files in `lib/internal/streams`

Open ankitzm opened this issue 1 year ago • 6 comments

I was building an app where I imported @toruslabs/base-controllers. The @toruslabs/base-controllers have readable-stream as a dev-dependency as listed in the package.json file. image

My node version: v18.14.1

Problem

When I ran my code, it threw the below error. Clearly, the error was because it couldn't find any process/ module as there is no such thing. image

The error was fixed when I changed all the process/ to process. As I was checking through the readable-stream repository, I found multiple typos in the process module in the repo. This might be breaking a lot of apps and I think this can be easily fixed with a single PR.

Solution

The typo needs to be fixed in these files 👇 image

I would love to work on the issue, let me know if I missed something. Thank You

ankitzm avatar Sep 21 '23 17:09 ankitzm