nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix(translation): don't translate OpenJS Foundation

Open avivkeller opened this issue 4 months ago • 8 comments

Fixes #8072

avivkeller avatar Sep 01 '25 14:09 avivkeller

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Updated (UTC)
nodejs-org Ready Ready Preview Sep 1, 2025 2:04pm

vercel[bot] avatar Sep 01 '25 14:09 vercel[bot]

[!NOTE]
Your Pull Request seems to be updating Translations of the Node.js Website.

Whilst we appreciate your intent; Any Translation update should be done through our Crowdin Project. We recommend giving a read on our Translation Guidelines.

Thank you!

github-actions[bot] avatar Sep 01 '25 14:09 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 76.60%. Comparing base (9f16142) to head (3691d39). :warning: Report is 84 commits behind head on main. :white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8129      +/-   ##
==========================================
+ Coverage   76.56%   76.60%   +0.04%     
==========================================
  Files         115      115              
  Lines        9595     9595              
  Branches      322      321       -1     
==========================================
+ Hits         7346     7350       +4     
+ Misses       2248     2244       -4     
  Partials        1        1              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 01 '25 14:09 codecov[bot]

In https://github.com/nodejs/nodejs.org/issues/8072 it was mentioned that at least in Chinese and Japanese, 'Foundation' would be expected to be translated so I'm not sure this is the answer?

mikeesto avatar Sep 02 '25 01:09 mikeesto

@bmuenzenmeyer did that conversation happen?

avivkeller avatar Sep 25 '25 21:09 avivkeller

I sent the email and it was affirmed as received and under review. I'm awaiting a response.

bmuenzenmeyer avatar Sep 25 '25 21:09 bmuenzenmeyer

Any updates?

bjohansebas avatar Oct 19 '25 18:10 bjohansebas

Any updates?

Not yet. I sent another ping to Robin and Legal

bmuenzenmeyer avatar Oct 19 '25 19:10 bmuenzenmeyer