nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: correct same level side navigation on breadcrumbs

Open tquocanvn opened this issue 9 months ago • 3 comments

Description

  • Update side bar navigation key name to match with route path in navigation.json
  • Add target side bar nav keys to HOC withBreadcrumbs.tsx to get directly sidebar navigation data for About.tsx and Learn.tsx page.
  • Update logic on matching route path in function getBreadrumbs of HOC withBreadcrumbs.tsx.

Validation

  • Open page path /en/about/, go through all items in side bar navigation to see it shows correct breadcrumbs data.

6679

Related Issues

Fixes #6679

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npm run format to ensure the code follows the style guide.
  • [x] I have run npm run test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [ ] I've covered new added functionality with unit tests if necessary.

tquocanvn avatar May 04 '24 17:05 tquocanvn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 4, 2024 5:11pm

vercel[bot] avatar May 04 '24 17:05 vercel[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 97 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 99 🟢 100 🟢 96 🟢 92 🔗

github-actions[bot] avatar May 04 '24 17:05 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 :zzz: 0 :x: 0 :fire: 6.137s :stopwatch:

github-actions[bot] avatar May 04 '24 17:05 github-actions[bot]

thanks for this thoughtful contribution @tquocanvn - sorry for the delay!

bmuenzenmeyer avatar May 21 '24 03:05 bmuenzenmeyer