nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

feat: Navigation state provider and hook

Open abizek opened this issue 9 months ago • 2 comments

Description

Adds a Navigation State provider and hook to track scroll position and restore it on remount.

Validation

2024-05-0408-39-39-ezgif com-video-to-gif-converter

Related Issues

Temporary workaround for #6409 Get more info here - #6675

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npm run format to ensure the code follows the style guide.
  • [ ] I have run npm run test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [ ] I've covered new added functionality with unit tests if necessary.

abizek avatar May 04 '24 03:05 abizek

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 16, 2024 7:15am

vercel[bot] avatar May 04 '24 03:05 vercel[bot]

~~Keeping this as a draft until I write the tests~~

abizek avatar May 04 '24 03:05 abizek

@abizek this is looking good! I left a few minor comments/suggestions and ideas :)

ovflowd avatar May 13 '24 10:05 ovflowd

@ovflowd I refactored the effect and responded to some of your comments. Please take a look.

abizek avatar May 14 '24 08:05 abizek

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 91 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟢 91 🔗
/en/about/previous-releases 🟢 100 🟢 100 🟢 100 🟢 92 🔗
/en/download 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 100 🟢 92 🔗

github-actions[bot] avatar May 14 '24 10:05 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 :zzz: 0 :x: 0 :fire: 6.342s :stopwatch:

github-actions[bot] avatar May 14 '24 10:05 github-actions[bot]