nodejs.org
nodejs.org copied to clipboard
fix: overflow issue on mobile GlowingBackdrop
Description
This PR aims to solve GlowingBackdrop overflow for the mobile resolution by limiting the container.
Validation
A glowing backdrop in the preview should not be wider than the content
Check List
- [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
- [x] I have run
npm run format
to ensure the code follows the style guide. - [x] I have run
npm run test
to check if all tests are passing. - [x] I have run
npx turbo build
to check if the website builds without errors. - [x] I've covered new added functionality with unit tests if necessary.
The latest updates on your projects. Learn more about Vercel for Git ↗︎
Name | Status | Preview | Updated (UTC) |
---|---|---|---|
nodejs-org | ✅ Ready (Inspect) | Visit Preview | May 1, 2024 1:23pm |
Lighthouse Results
URL | Performance | Accessibility | Best Practices | SEO | Report |
---|---|---|---|---|---|
/en | 🟢 98 | 🟢 100 | 🟢 100 | 🟢 91 | 🔗 |
/en/about | 🟢 100 | 🟢 100 | 🟢 96 | 🟢 91 | 🔗 |
/en/about/previous-releases | 🟢 99 | 🟢 98 | 🟢 100 | 🟢 92 | 🔗 |
/en/download | 🟢 99 | 🟢 100 | 🟢 100 | 🟢 91 | 🔗 |
/en/blog | 🟢 98 | 🟢 100 | 🟢 96 | 🟢 92 | 🔗 |
Unit Test Coverage Report
Lines | Statements | Branches | Functions |
---|---|---|---|
90.04% (588/653) | 76.08% (175/230) | 92.18% (118/128) |
Unit Test Report
Tests | Skipped | Failures | Errors | Time |
---|---|---|---|---|
128 | 0 :zzz: | 0 :x: | 0 :fire: | 5.816s :stopwatch: |
I think there is also a problem with the centering of the gradient 🤔
odd - i wonder if this was a regression
odd - i wonder if this was a regression
Probably a regression for when we switched to use a React Component as the Backdrop? Instead of a background CSS attribute?
~I'm fast tracking this as it seems quite an ugly bug.~ Actually, not, have a pending question.
@canerakdas even if the glowing part is centered now, apparently the Hexagon itself is not. I have the feeling instead of using overflow-hidden we should actually limit the size of the Hexagon/center it?
odd - i wonder if this was a regression
It looks like a regression, I noticed it while randomly browsing the website 🤔
even if the glowing part is centered now, apparently the Hexagon itself is not. I have the feeling instead of using overflow-hidden we should actually limit the size of the Hexagon/center it?
I have updated the svg size according to the aspect ratio 🎉