nodejs.org icon indicating copy to clipboard operation
nodejs.org copied to clipboard

fix: overflow issue on mobile GlowingBackdrop

Open canerakdas opened this issue 9 months ago • 10 comments

Description

This PR aims to solve GlowingBackdrop overflow for the mobile resolution by limiting the container.

Validation

A glowing backdrop in the preview should not be wider than the content

Check List

  • [x] I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • [x] I have run npm run format to ensure the code follows the style guide.
  • [x] I have run npm run test to check if all tests are passing.
  • [x] I have run npx turbo build to check if the website builds without errors.
  • [x] I've covered new added functionality with unit tests if necessary.

canerakdas avatar Apr 30 '24 22:04 canerakdas

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview May 1, 2024 1:23pm

vercel[bot] avatar Apr 30 '24 22:04 vercel[bot]

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 96 🟢 91 🔗
/en/about/previous-releases 🟢 99 🟢 98 🟢 100 🟢 92 🔗
/en/download 🟢 99 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 98 🟢 100 🟢 96 🟢 92 🔗

github-actions[bot] avatar Apr 30 '24 22:04 github-actions[bot]

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 91%
90.04% (588/653) 76.08% (175/230) 92.18% (118/128)

Unit Test Report

Tests Skipped Failures Errors Time
128 0 :zzz: 0 :x: 0 :fire: 5.816s :stopwatch:

github-actions[bot] avatar Apr 30 '24 22:04 github-actions[bot]

I think there is also a problem with the centering of the gradient 🤔

canerakdas avatar Apr 30 '24 23:04 canerakdas

odd - i wonder if this was a regression

bmuenzenmeyer avatar May 01 '24 03:05 bmuenzenmeyer

odd - i wonder if this was a regression

Probably a regression for when we switched to use a React Component as the Backdrop? Instead of a background CSS attribute?

ovflowd avatar May 01 '24 07:05 ovflowd

~I'm fast tracking this as it seems quite an ugly bug.~ Actually, not, have a pending question.

ovflowd avatar May 01 '24 07:05 ovflowd

@canerakdas even if the glowing part is centered now, apparently the Hexagon itself is not. I have the feeling instead of using overflow-hidden we should actually limit the size of the Hexagon/center it?

ovflowd avatar May 01 '24 07:05 ovflowd

odd - i wonder if this was a regression

It looks like a regression, I noticed it while randomly browsing the website 🤔

canerakdas avatar May 01 '24 13:05 canerakdas

even if the glowing part is centered now, apparently the Hexagon itself is not. I have the feeling instead of using overflow-hidden we should actually limit the size of the Hexagon/center it?

I have updated the svg size according to the aspect ratio 🎉

canerakdas avatar May 01 '24 13:05 canerakdas